[bitnami/thanos] addition of parameter to configure statefulset annotations #33988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomHellier
force-pushed
the
33987-add-statefulset-annotations-to-thanos-receive
branch
from
f6937a7 to
4ba76f2
Compare
javsalgar
added
verify
|
Hi @TomHellier, Thank you for your contribution and I'm sorry for the late response. Would it be possible to include this feature for all of Thanos statefulsets? |
|
Hey, yes I will do this over next couple of days |
|
Thank you! Feel free to ping me whenever it is ready for review again and let me know if you need any help. |
TomHellier
force-pushed
the
33987-add-statefulset-annotations-to-thanos-receive
branch
5 times, most recently
from
f9a09d6 to
b1fa467
Compare
…ations applied to thanos receive/storegateway/ruler Also fixes bug introduced in bitnami#34825 Signed-off-by: Tom Hellier <[email protected]>
TomHellier
force-pushed
the
33987-add-statefulset-annotations-to-thanos-receive
branch
from
b1fa467 to
1598bfd
Compare
|
@migruiz4 - I think I've got this with the changes you wanted, also it fixes a bug in recent PR #34825 https://github.com/bitnami/charts/pull/34825/files#r2194446107 |
Signed-off-by: Miguel Ruiz <[email protected]> Signed-off-by: Miguel Ruiz <[email protected]>
migruiz4
previously approved these changes
Jul 9, 2025
Signed-off-by: Bitnami Bot <[email protected]>
migruiz4
approved these changes
Jul 9, 2025
nicolas-laduguie
pushed a commit
to nicolas-laduguie/bitnami-charts
that referenced
this pull request
Jul 9, 2025
…ations (bitnami#33988) * [bitnami/thanos] addition of parameter to configure statefulset annotations applied to thanos receive/storegateway/ruler Also fixes bug introduced in bitnami#34825 Signed-off-by: Tom Hellier <[email protected]> * Bump minor version Signed-off-by: Miguel Ruiz <[email protected]> Signed-off-by: Miguel Ruiz <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Bot <[email protected]> --------- Signed-off-by: Tom Hellier <[email protected]> Signed-off-by: Miguel Ruiz <[email protected]> Signed-off-by: Bitnami Bot <[email protected]> Co-authored-by: Miguel Ruiz <[email protected]> Co-authored-by: Bitnami Bot <[email protected]> Signed-off-by: Nicolas Laduguie <[email protected]>
anishmanocha
pushed a commit
to anishmanocha/charts
that referenced
this pull request
Jul 10, 2025
…ations (bitnami#33988) * [bitnami/thanos] addition of parameter to configure statefulset annotations applied to thanos receive/storegateway/ruler Also fixes bug introduced in bitnami#34825 Signed-off-by: Tom Hellier <[email protected]> * Bump minor version Signed-off-by: Miguel Ruiz <[email protected]> Signed-off-by: Miguel Ruiz <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Bot <[email protected]> --------- Signed-off-by: Tom Hellier <[email protected]> Signed-off-by: Miguel Ruiz <[email protected]> Signed-off-by: Bitnami Bot <[email protected]> Co-authored-by: Miguel Ruiz <[email protected]> Co-authored-by: Bitnami Bot <[email protected]> Signed-off-by: Anish Manocha <[email protected]>
mboutet
pushed a commit
to mboutet/charts
that referenced
this pull request
Jul 14, 2025
…ations (bitnami#33988) * [bitnami/thanos] addition of parameter to configure statefulset annotations applied to thanos receive/storegateway/ruler Also fixes bug introduced in bitnami#34825 Signed-off-by: Tom Hellier <[email protected]> * Bump minor version Signed-off-by: Miguel Ruiz <[email protected]> Signed-off-by: Miguel Ruiz <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Bot <[email protected]> --------- Signed-off-by: Tom Hellier <[email protected]> Signed-off-by: Miguel Ruiz <[email protected]> Signed-off-by: Bitnami Bot <[email protected]> Co-authored-by: Miguel Ruiz <[email protected]> Co-authored-by: Bitnami Bot <[email protected]> Signed-off-by: Maxence Boutet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds annotations and labels to thanos receive/storegateway/ruler statefulset
Benefits
Greater configurability
Possible drawbacks
n/a
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm